Ugly bug in UploadModule

  •  03-16-2012, 11:17 AM

    Ugly bug in UploadModule

    Hi, i was interested in buying your ajaxuploader and tested in my environment
     
    i found a really ugly bug in  UploadModule.HandleResource method
     
    you look for the header If-Modified-Since
     
    and if it is present you DateTime.Parse it
     
    the problem is that you don't provide an IformatProvider neither use tryparse or a try catch block
     
    so if an application is localized this throw a System.FormatException: String was not recognized as a valid DateTime.
     
    you should use DateTime.Parse(stringToParse, System.Globalization.CultureInfo.InvariantCulture) in this situation because this header uses RFC1123 for dates
     
    this is a beginner bug...
     
    you cannot sell wordwide your components and don't use IFormatProvider when parsing strings...
     
     
     
     
View Complete Thread